fix(Product sync): Avoid setting None for missing fields. Use model d…

…efault values instead (#519)
openfoodfacts · Oct 13, 2024 · e3ed44e · e3ed44e
1 parent 07e42bc
commit e3ed44e
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/open_prices/common/openfoodfacts.py b/open_prices/common/openfoodfacts.py
@@ -198,14 +198,15 @@ def import_product_db(flavor: Flavor = Flavor.off, batch_size: int = 1000) -> No
             continue
 
         # Build product dict to create/update
-        product_dict = {
-            key: product[key] if (key in product) else None for key in OFF_CREATE_FIELDS
-        }
+        product_dict = dict()
+        product_dict["source"] = flavor
+        product_dict["source_last_synced"] = timezone.now()
+        for off_field in OFF_CREATE_FIELDS:
+            if off_field in product:
+                product_dict[off_field] = product[off_field]
         product_dict["image_url"] = generate_main_image_url(
             product_code, product_images, product_lang, flavor=flavor
         )
-        product_dict["source"] = flavor
-        product_dict["source_last_synced"] = timezone.now()
         product_dict = normalize_product_fields(product_dict)
 
         # Case 1: new OFF product (not in OP database)