fix(Proofs): Deny users to delete a proof with prices #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested: "Cannot delete proof with associated prices" 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently the API allows users to delete proofs even if the proof has prices.
(it would not delete prices, but set their proof_id to None)
To enforce data quality, and avoid mistakes, we restrict the deletion to only proofs with 0 prices.
Pending questions
What if the user linked the prices to a wrong proof for instance ? Will need to upload a new proof first, and the prices again to this new proof (maybe allow one day to update the price's proof, or update the proof image ?)
Linked PRs