feat: add Price.product_name field #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
commented
Dec 13, 2023
| product_code: str | None = Field( | ||
| default=None, | ||
| min_length=1, | ||
| pattern="^[0-9]+$", | ||
| description="barcode (EAN) of the product, as a string.", | ||
| examples=["16584958", "8001505005707"], | ||
| ) | ||
| product_name: str | None = Field( |
There was a problem hiding this comment.
@raphael0202 in terms of naming, I hesitated with product_label and product_tag. But there are the existing category_tag & labels_tags so it could be confusing... or maybe product_store_label ? or product_name_in_store ?
There was a problem hiding this comment.
product_name sounds good to be!
raphael0202
reviewed
Dec 14, 2023
raphael0202
reviewed
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
New field
Price.product_nameto store the product name displayed in the stores. We have this info on the proof images, but also on the receipts and in the GDPR requests.Screenshot