-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #370 - added "uuid" to configuration #378
feat: #370 - added "uuid" to configuration #378
Conversation
Impacted files: * `configuration_test.dart`: added tests with "uuid" * `HttpHelper.dart`: included new static `uuid` to parameters * `OpenFoodAPIConfiguration.dart`: added `static String? uuid` * `pubspec.yaml`: unrelated upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @monsieurtanuki
Thank you @M123-dev for your review! |
@monsieurtanuki thank you for the changes. Maybe updating the readMe and the example file can help ? |
That's something we can add to https://github.com/openfoodfacts/openfoodfacts-dart/projects/2 |
Fair enough @MohamedFBoussaid, but I don't know
It's looked so far like uuid should be populated by a device id, but that's not supported by (agnostic) dart. Only by flutter. |
@monsieurtanuki I can give it a try with my Flutter app, and see how it will work. And then I will be back with examples Future<String?> _getId() async { |
Thank you @MohamedFBoussaid! |
Thanks @monsieurtanuki I will use that package. |
@monsieurtanuki , I have made a quick test using that package. And normally I made a fake update for a product 7613035989535 with the following UUIDs :
@stephanegigandet @teolemon is there a way to check if the UUID was received on the backend ? |
I've just added uuid to smoothie too (openfoodfacts/smooth-app#1064) |
Impacted files:
configuration_test.dart
: added tests with "uuid"HttpHelper.dart
: included new staticuuid
to parametersOpenFoodAPIConfiguration.dart
: addedstatic String? uuid
pubspec.yaml
: unrelated upgrade