Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multipart requests: ensure to always get the full response #779

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Aug 9, 2023

Hi everyone,

We have a major issue with POST requests, where we only get a part of the response (first from a Stream).
This PR ensures to get the full response

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #779 (34208a2) into master (4043044) will decrease coverage by 0.08%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   73.11%   73.03%   -0.08%     
==========================================
  Files         203      203              
  Lines        7408     7416       +8     
==========================================
  Hits         5416     5416              
- Misses       1992     2000       +8     
Files Changed Coverage Δ
lib/src/utils/http_helper.dart 72.15% <73.33%> (-1.09%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit e53c7fd into master Aug 9, 2023
4 checks passed
@teolemon teolemon deleted the multipart_body_fix branch August 9, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants