fix: added "app_name" parameter for prices methods uploadProof and createPrice

[monsieurtanuki]

What

• Now we pass an app_name parameter to prices methods uploadProof and createPrice, for tracking purposes.
• Meanwhile, some refactoring, including trying to make all tests pass.
• And some new prices methods somehow needed by Smoothie.

Impacted files

• api_get_taxonomy_origins_server_test.dart: minor refactoring
• api_get_user_products_test.dart: set max page size to new server max page size (100)
• api_search_products_test.dart: set default page size to new server default page size (50)
• api_suggestion_manager_test.dart: now targeting PROD; minor refactoring
• currency.dart: new fromName method
• open_prices_api_client.dart: added app_name parameter for uploadProof and createPrice; refactored around new method getUri
• page_size.dart: added comments
• price.dart: added comments
• proof.dart: new getFileUrl method; added comments
• proof_type.dart: new fromOffTag method

[monsieurtanuki]

cc @raphodn @raphael0202

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 83.72093% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.20%. Comparing base (820d145) to head (641d195).
Report is 34 commits behind head on master.

Files	Patch %	Lines
lib/src/prices/currency.dart	0.00%	3 Missing ⚠️
lib/src/prices/proof_type.dart	0.00%	2 Missing ⚠️
test/api_search_products_test.dart	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   76.34%   75.20%   -1.15%     
==========================================
  Files         239      247       +8     
  Lines        8494     8881     +387     
==========================================
+ Hits         6485     6679     +194     
- Misses       2009     2202     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[raphodn]

Fyi in the prices web app I opted to pass the app_name in the URL of every request (so not only POST, but also GET).

I guess in Sentry if there are any errors, the User Agent is sent and available in any case. But i realised that some browsers do not allow to edit the UA (for instance Chrome).

[monsieurtanuki]

Fyi in the prices web app I opted to pass the app_name in the URL of every request (so not only POST, but also GET).

DELETE and PATCH too?

[raphodn]

Yes every call to the API 👌

And you can send extra info like the app_version and any other relevant data as extra url params if you want.

I need to document at least the app_name in the API documentation

[monsieurtanuki]

@raphodn I've just pushed a change where all prices URLs will include "user agent" fields (when populated):

• app_name
• app_version (optional)
• app_uuid (optional)
• app_platform (optional)
• comment (optional)

With the exception of the proof file URL where we don't add those parameters, e.g. https://prices.openfoodfacts.net/img/0002/yRw3zcph08.jpg

[M123-dev]

Looks good, thanks @monsieurtanuki

[monsieurtanuki]

Thank you @M123-dev for your reviews!