feat: 956 - added product owner fields #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `owner_field.dart`: Helper class to compute the Product.ownerFields tags. Impacted files: * `api_get_product_test.dart`: added a test for owner fields * `openfoodfacts.dart`: added new class `OwnerField` * `product.dart`: added field `ownerFields` and method `getOwnerFieldTimestamp` * `product.g.dart`: generated * `product_fields.dart`: refactored around localized product fields
teolemon
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks @monsieurtanuki 👍
The first step for protected products explainability
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Files
New file:
owner_field.dart: Helper class to compute the Product.ownerFields tags.Impacted files:
api_get_product_test.dart: added a test for owner fieldsopenfoodfacts.dart: added new classOwnerFieldproduct.dart: added fieldownerFieldsand methodgetOwnerFieldTimestampproduct.g.dart: generatedproduct_fields.dart: refactored around localized product fields