Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Laravel 10 support to the Open Food Facts package #39

Closed
khalyomede opened this issue Feb 15, 2023 · 7 comments
Closed

Add Laravel 10 support to the Open Food Facts package #39

khalyomede opened this issue Feb 15, 2023 · 7 comments
Labels
✨ enhancement New feature or request

Comments

@khalyomede
Copy link

khalyomede commented Feb 15, 2023 •
edited
Loading

Problem

I want to upgrade to Laravel 10 and the package does not support it.

Proposed solution

Add support for Laravel 10.

Additional context

Mockups

Part of
@khalyomede khalyomede added the ✨ enhancement New feature or request label Feb 15, 2023
@khalyomede khalyomede changed the title Laravel 10 suppo Laravel 10 support Feb 15, 2023
This was referenced Feb 15, 2023
Closed
Closed
@fogbreaker
Copy link

bump

@kaemmi84
Copy link

I also need Laravel 10 support :(

@mpoweredo
Copy link

bump

@teolemon
Copy link
Member

Can we merge openfoodfacts/openfoodfacts-php#47 ?

@teolemon
Copy link
Member

It drops php7 it seems. Is that problematic?

@epalmans
Copy link
Member

as long as we tag it as a new "major" release (1.x or 0.3.x), then I don't see any problems.

@teolemon teolemon changed the title Laravel 10 support Add Laravel 11 support to the Open Food Facts package May 1, 2024
@teolemon teolemon changed the title Add Laravel 11 support to the Open Food Facts package Add Laravel 10 support to the Open Food Facts package May 1, 2024
@teolemon
Copy link
Member

teolemon commented May 1, 2024

@epalmans epalmans mentioned this issue May 1, 2024
Merged
@epalmans epalmans closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
🍊🐘 Open Food Facts PHP SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@teolemon @kaemmi84 @epalmans @khalyomede @fogbreaker @mpoweredo