Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for psr/log ^2.0 #46

Conversation

khalyomede
Copy link

What

Adds support for psr/log ^2.0 (which blocks a pull request, see Part of section).

Screenshot

Fixes bug(s)

Part of

@khalyomede khalyomede requested a review from a team as a code owner February 15, 2023 21:02
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khalyomede khalyomede changed the title #45 add support for psr/log ^2.0 feat: #45 add support for psr/log ^2.0 Feb 15, 2023
@khalyomede khalyomede changed the title feat: #45 add support for psr/log ^2.0 feat: add support for psr/log ^2.0 Feb 15, 2023
@Dwarfex Dwarfex changed the base branch from develop to 0.3.x-dev February 16, 2023 17:06
@Dwarfex
Copy link
Member

Dwarfex commented Feb 16, 2023

I 'll combine this with a new Version and update PHP too - sry for beeing late to the party

@Dwarfex Dwarfex self-requested a review February 16, 2023 19:41
@Dwarfex
Copy link
Member

Dwarfex commented Feb 16, 2023

see #47 - Code Style fixes there are still needed

@khalyomede
Copy link
Author

Well, I see 0.3.x-dev already contains expected changes (even better because psr/log is at ^3.0). I will close this pull request and my issue will be solved when 0.3.0 is published. Sorry for the time loss...

@khalyomede khalyomede closed this Feb 16, 2023
@khalyomede khalyomede deleted the 45-add-support-for-psr-log-2-0-or-3-0 branch February 16, 2023 21:30
@Dwarfex
Copy link
Member

Dwarfex commented Feb 19, 2023

Absolutely no reason to be sorry! - Thx for pushing for improvement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants