Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automatic release to PyPI + fix: failing flake8 tests #88

Merged
merged 4 commits into from
Apr 7, 2022
Merged

feat: Automatic release to PyPI + fix: failing flake8 tests #88

merged 4 commits into from
Apr 7, 2022

Conversation

aadarsh-ram
Copy link
Contributor

@aadarsh-ram aadarsh-ram commented Apr 6, 2022 •
edited
Loading

Fixes issues

Solution

  • Added pypi.yml for automatic PyPI release using GitHub Actions. (untested due to secret API Token)
  • Updated version for release from 0.1.2 to 0.1.3
  • Added a #noqa tag for the F821 error.
  • Removed draft.py, since existing code (utils.py and init.py) is not dependent on it. File deletion fixes the E999 error.
  • Edited Usage.md for a minor variable correction.

If this PR is accepted, #82 can be closed.

Hope to contribute more to OpenFoodFacts!

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner April 6, 2022 18:01
@aadarsh-ram aadarsh-ram changed the title Added workflow. Updated version and docs. Delete draft.py feat: Automatic release to PyPI + fix: flake8 tests Apr 6, 2022
@aadarsh-ram aadarsh-ram changed the title feat: Automatic release to PyPI + fix: flake8 tests feat: Automatic release to PyPI + fix: failing flake8 tests Apr 7, 2022
alexgarel
alexgarel approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @aadarsh-ram

I just added a suggestion.

.github/workflows/pypi.yml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel mentioned this pull request Apr 7, 2022
Closed
@alexgarel alexgarel merged commit ec3fa56 into openfoodfacts:develop Apr 7, 2022
This was referenced Apr 8, 2022
Closed
Closed
This was linked to issues Apr 10, 2022
Add automatic release using GitHub Actions #75
Closed
Tests are failing #77
Closed
KeyError: 'products' when trying to access ingredients #81
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@aadarsh-ram aadarsh-ram

Labels
None yet
Projects
🐍 Python SDK - Keep on par with the API
Status: To do
Milestone
No milestone
2 participants
@aadarsh-ram @alexgarel