fix: re-activate critic rule (#10031)

openfoodfacts · Mar 26, 2024 · 493c5c8 · 493c5c8
1 parent e9174c2
commit 493c5c8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.perlcriticrc b/.perlcriticrc
@@ -17,7 +17,7 @@ only 		= 1
 [Modules::ProhibitEvilModules]
 [Modules::RequireBarewordIncludes]
 
-[-Modules::RequireFilenameMatchesPackage]
+[Modules::RequireFilenameMatchesPackage]
 
 [Subroutines::ProhibitExplicitReturnUndef]
 [Subroutines::ProhibitNestedSubs]

diff --git a/Makefile b/Makefile
@@ -359,6 +359,8 @@ lint_perltidy:
 
 #Checking with Perl::Critic
 # adding an echo of search.pl in case no files are edited
+# note: to run a complete critic on all files (when you change policy), use:
+# find . -regex ".*\.\(p[lM]\|t\)"|grep -v "/\."|grep -v "/obsolete/"|xargs docker compose run --rm --no-deps -T backend perlcritic
 check_critic:
 	@echo "🥫 Checking with perlcritic"
 	test -z "${TO_CHECK}" || ${DOCKER_COMPOSE} run --rm --no-deps backend perlcritic ${TO_CHECK}