Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a taxonomy linter and lint properties #10039

Closed
alexgarel opened this issue Mar 27, 2024 · 0 comments · Fixed by #10046
Closed

Create a taxonomy linter and lint properties #10039

alexgarel opened this issue Mar 27, 2024 · 0 comments · Fixed by #10046
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies

Comments

@alexgarel
Copy link
Member

We have several problems we can solve at once:

  • if a property is named after an existing taxonomy we would like to replace values by normalized values corresponding to id of entry in referenced taxonomy (because it is hard to do at taxonomy build time)
  • we want to avoid having more than one line per language for one entry
  • we want to avoid git auto merges to join two distinct entries
    • this can be detected if more than one line for same language (see above)
    • or if we have a < in the middle of an entry
  • we would like to keep taxonomies sorted (in the near future)

For that we need a taxonomy linter than can act in modify or check mode.

@teolemon teolemon added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants