ci: taxonomy linter #10046
Merged
ci: taxonomy linter #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧬 Taxonomies
github-actions
bot
added
🧴 Open Beauty Facts
+ small perf improvement using first instead of grep
alexgarel
commented
Mar 29, 2024
Co-authored-by: Stéphane Gigandet <[email protected]>
| @@ -3354,12 +3354,12 @@ wikipedia:en:https://en.wikipedia.org/wiki/Calcium_carbonate | |||
| # ingredient/calcium-carbonate has 4220 products in 10 languages @2019-02-03 | |||
| # mineral/calcium-carbonate has 4301 products @2019-02-03 | |||
| e_number:en:170 | |||
| mandatory_additive_class:en: en:acidity-regulator, en:anti-caking-agent, en:stabilizer, en:firming-agent, en:flour-treatment-agent, en:glazing-agent, en:colour | |||
There was a problem hiding this comment.
It looks like you manually changed all occurences of en:stabilizer to en:stabiliser, but did not run "make lint_taxonomies" fully on additives.txt ?
There was a problem hiding this comment.
Because I wanted to do it in another PR (but needed this stabliser change to have test pass !)
…dfacts-server into ci-taxonomies-lint
Co-authored-by: Stéphane Gigandet <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taxonomy check is not yet activated because I want to separate the PR where we will lint and fix taxonomies…
you can test it locally with make check_taxonomies or make lint_taxonomies