Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of information in (and about) revision pages #1945

Closed
CharlesNepote opened this issue Jun 18, 2019 · 3 comments · Fixed by #2070
Closed

Lack of information in (and about) revision pages #1945

CharlesNepote opened this issue Jun 18, 2019 · 3 comments · Fixed by #2070
Assignees
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality ✨ Feature Features or enhancements to Open Food Facts server frontend P2

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented Jun 18, 2019

In revision pages, some informations are missing or hard to find:

  • timestamp
  • contributor name
  • revision content (ex. Selected images (Changed: nutrition_fr) - new image nutrition_fr : 25.72)
  • revision source
  • the link to the last revision of the product

To find these informations you have to go to "Changes history" at the bottom and find which entry match to current revision (with mouse over "view" link).

Also, for a beginner, it's difficult to understand that this is an old version of the product.

Related to this issue, each "Changes history" entry is poor:
<li><time datetime="2018-06-10T15:06:20">June 10, 2018 at 3:06:20 PM CEST</time> - <a href="/contributor/kiliweb">kiliweb</a> Nutriments (Changed: energy, fat, saturated-fat, proteins) - (app)User : UUpsZkc3WUIvLzlSdmZZQndSZkY2K0p6ekxhcUF6bUdjN0UrSVE9PQ - <a href="/product/3095756220014/fleuron-de-canard-fleury-michon?rev=40">view</a></li>

I suggest either or both:

  • show these informations at the beginning of the page, in a way that clearly shows that this is an old revision; this informations should be presented with semantic code (example below)
  • modify "Changes history" entries to let designers and coders better use "Changes history" informations

Example of code for warning revision block

<div id="rev_summary">
<span class="rev_warning">This page is an old revision this product.</span> 
Rev. <span class="rev_nb">40</span> 
produced on <time datetime="2018-06-10T15:06:20">June 10, 2018 at 3:06:20 PM CEST</time> 
by <a href="/contributor/kiliweb" class="rev_contributor">kiliweb</a>, 
who changed <span class="rev_changes">Nutriments (Changed: energy, fat, saturated-fat, proteins)</span> 
from source <span class="rev_source">(app)User : UUpsZkc3WUIvLzlSdmZZQndSZkY2K0p6ekxhcUF6bUdjN0UrSVE9PQ</span>.<br/>
Link to this revision: <a href="/product/3095756220014/fleuron-de-canard-fleury-michon?rev=40">view</a><br/>
Link to last revision: <a href="/product/3095756220014/fleuron-de-canard-fleury-michon">view</a>
</div>

Example of Changes history entry

<li id="rev_40" class="rev_set"><!-- <= add class="current" if it matches current revision -->
Rev. <span class="rev_nb">40</span> - 
<time datetime="2018-06-10T15:06:20">June 10, 2018 at 3:06:20 PM CEST</time> - 
<a href="/contributor/kiliweb" class="rev_contributor">kiliweb</a> 
<span class="rev_changes">Nutriments (Changed: energy, fat, saturated-fat, proteins)</span> - 
<span class="rev_source">(app)User : UUpsZkc3WUIvLzlSdmZZQndSZkY2K0p6ekxhcUF6bUdjN0UrSVE9PQ</span> - 
<a class="rev_link">href="/product/3095756220014/fleuron-de-canard-fleury-michon?rev=40">view</a>
</li>`

Solving this issue will help solve #1408.

@CharlesNepote CharlesNepote added 🐛 bug This is a bug, not a feature request. ✨ Feature Features or enhancements to Open Food Facts server frontend 🧽 Data quality https://wiki.openfoodfacts.org/Quality P2 and removed 🐛 bug This is a bug, not a feature request. labels Jun 18, 2019
@VaiTon
Copy link
Member

VaiTon commented Jun 19, 2019

image
This is how wikipedia does it

@CharlesNepote
Copy link
Member Author

That's it @VaiTon! I think we could reuse nearly the same sentence. I guess we could use <div class="panel callout">..............</div> to do it?

Would you work on that @VaiTon? You're doing a great job and this would help to solve #1408.

@VaiTon
Copy link
Member

VaiTon commented Jun 23, 2019

Sure! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality ✨ Feature Features or enhancements to Open Food Facts server frontend P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants