Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show information about current revision if not latest #2070

Merged
merged 8 commits into from
Jul 16, 2019
Merged

Show information about current revision if not latest #2070

merged 8 commits into from
Jul 16, 2019

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Jul 8, 2019 •
edited
Loading

Partially fixes #1945

@VaiTon VaiTon self-assigned this Jul 8, 2019
@VaiTon VaiTon added 🎨 Design product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements responsive ux labels Jul 8, 2019
@VaiTon
Copy link
Member Author

VaiTon commented Jul 8, 2019

image

@VaiTon VaiTon marked this pull request as ready for review July 8, 2019 12:47
@CharlesNepote
Copy link
Member

Great! As in wikipedia, would you use a symbol to make a visual separation between previous version, latest version and next version? Wikipedia uses a pipe (|).

image

hangy
hangy approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@hangy hangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@VaiTon
Copy link
Member Author

VaiTon commented Jul 8, 2019

Great! As in wikipedia, would you use a symbol to make a visual separation between previous version, latest version and next version? Wikipedia uses a pipe (|).

image

Is this really necessary? I really like its look without any symbol between links. XD

@VaiTon
Copy link
Member Author

VaiTon commented Jul 8, 2019

The last thing i would like to add is the comment and the changes.

@VaiTon
Copy link
Member Author

VaiTon commented Jul 9, 2019

@stephanegigandet @hangy from TravisCI

Package graphviz is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

@VaiTon VaiTon merged commit c0225f1 into openfoodfacts:master Jul 16, 2019
@VaiTon VaiTon deleted the issues/1945-rev-info branch July 16, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangy hangy hangy approved these changes

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@VaiTon VaiTon

Labels
🎨 Design product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements responsive ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of information in (and about) revision pages
4 participants
@VaiTon @CharlesNepote @hangy @stephanegigandet