Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutri-score-grade error inadvertently triggered #9297

Closed
aleene opened this issue Nov 11, 2023 · 1 comment · Fixed by #9461
Closed

Nutri-score-grade error inadvertently triggered #9297

aleene opened this issue Nov 11, 2023 · 1 comment · Fixed by #9461
Assignees
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality

Comments

@aleene
Copy link
Contributor

aleene commented Nov 11, 2023

What

A product belonging to the olive oils category AND olive oil as ingredient triggers an error en:Nutri-score-grade-from-category-does-not-match-calculated-grade. There is no grade calculated, so why?

Steps to reproduce the behaviour

see https://nl.openfoodfacts.org/product/8718907514255/extra-vierge-olijfolie-albert-heijn-bio

Expected behaviour

There is no actual error, just lacking data. So no error expected. By the way the nutriscore can be forced through ingredients and/or category.

Why

This should not trigger a nutriscore error as it can not be repaired. The corresponding state for lacking nutritional data is sufficient (which might be used to suppress the error.

@aleene aleene changed the title Nutriscore triggerd Nutri-score-grade error inadvertently triggered Nov 11, 2023
@teolemon teolemon added 🧽 Data quality https://wiki.openfoodfacts.org/Quality Nutri-Score labels Nov 11, 2023
@benbenben2
Copy link
Collaborator

It expects grade C and the product has no grade (no picture for nutrition table, hence not possible to add the data).

Technically, the error is correct. But practically, it cannot be fixed without having a picture of the table.

Hence, suggested solution: do not trigger the error if:

  • nothing is entered in the nutrition table, or
  • "Nutrition facts are not specified on the product." is checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants