Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dq_nutriscore_alert_and_category_rework #9461

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: dq_nutriscore_alert_and_category_rework #9461

merged 1 commit into from
Dec 4, 2023

Conversation

benbenben2
Copy link
Collaborator

What

Categories with expected nutriscore should not raise error when not enough nutrients are provided. Because it could be that picture of nutrition table is missing and it could not be fixed.

do not trigger the error if:

nothing is entered in the nutrition table, or
"Nutrition facts are not specified on the product." is checked

Related issue(s) and discussion

@benbenben2 benbenben2 added 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 Data quality - Nutrition labels Dec 1, 2023
@benbenben2 benbenben2 self-assigned this Dec 1, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner December 1, 2023 20:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 8a81fc7 into main Dec 4, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the dq_nutriscore_alert_and_category_rework branch December 4, 2023 09:36
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@benbenben2 benbenben2

Labels
🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nutri-score-grade error inadvertently triggered
2 participants
@benbenben2 @stephanegigandet