-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New knowledge panels properties: half size panel + very short title and description #9368
Comments
@stephanegigandet @alexgarel Data that is currently missing from the server side that I've noticed in openfoodfacts/smooth-app#4890 (about the Nutriscore panel only):
Besides, assuming that the percentage is the percentage of nutrient quantity in grams:
|
I've started looking into this (also referring to openfoodfacts/smooth-app#4889). Initial observations: There seem to be three pieces of information that need to be conveyed:
For the name of the attribute, this should already exist and be consistent with the name used when users are selecting their food preferences. For the value of the attribute I'm not sure a double is going to work for attributes like Packaging and Species threat, so it may be we need to keep this as text (and fix the decimal separator on the server side). It looks like the existing undocumented "evaluation" property could be used to indicate good / bad. |
Update. We already have a "type" to indicate grade, so expanding this to include "percentage" allows the value to be supplied as a raw number, so regional formatting can be done on the client |
Scope:
|
@teolemon as we have the include / exclude knowledge panels parameters, I would better add a condensed_knowledge_panels=panel1,panel2 etc. which means include the knowledge panel, in condensed form. |
On mobile (app + web) we want to show some panels in a more condensed way, 2 by 2:
We need to define new properties for specifying that the panel should be shown half size on mobile, and add very short titles and descriptions.
Part of
The text was updated successfully, but these errors were encountered: