feat: 4889 - new simplified nutriscore widget

[monsieurtanuki]

What

• This PR adds a simplified version of the nutriscore display conform to the big redesign, on top of the KP and only if the "reordering KP" flag is set on DEV mode.
• While coding, several questions:
  • Should we try to be a11n compliant? At least I tried with colors AND icons. Can easily be turned off back to "just the color"
  • We don't have any localizations for "salt", and I don't know if we should expect them from the server or if we should localize them in the app
  • I had to extract the data from the server (e.g. "1.2%") - again, should the server provide us with that raw data?
• The simplified nutriscore is about 50% less tall than the current version. That goes in the right direction.

Screenshots

test 1	test 2

Fixes bug(s)

• Fixes: Display simplified nutriscore widget #4889

Files

New files:

• evaluation_extension.dart: a11y helper for Evaluation.
• knowledge_panel_enum.dart: Helper around knowledge panel ids.
• knowledge_panel_simplified_row.dart: Row that displays two widgets on same width columns (half max width).
• knowledge_panel_simplified_title.dart: Full width title for a simplified knowledge panel.
• knowledge_panel_simplified_widget.dart: Simplified widget for knowledge panel.
• nutriscore_simplified_widget.dart: Simplified nutriscore widget, with nutriscore and 4 other attributes.

Impacted files:

• knowledge_panel_title_card.dart: moved code to new class EvaluationExtension
• new_product_page.dart: added simplified nutriscore widget triggered by dev mode only
• reorderable_knowledge_panel_page.dart: minor refactoring using new class KnowledgePanelEnum

[codecov-commenter]

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (85784fa) 9.62% compared to head (866fab4) 9.56%.

Files	Patch %	Lines
...ig_redesign/knowledge_panel_simplified_widget.dart	0.00%	54 Missing ⚠️
...big_redesign/knowledge_panel_simplified_title.dart	0.00%	26 Missing ⚠️
...uct/big_redesign/nutriscore_simplified_widget.dart	0.00%	17 Missing ⚠️
...ges/product/big_redesign/evaluation_extension.dart	0.00%	14 Missing ⚠️
...t/big_redesign/knowledge_panel_simplified_row.dart	0.00%	8 Missing ⚠️
...l/knowledge_panels/knowledge_panel_title_card.dart	0.00%	2 Missing ⚠️
...smooth_app/lib/pages/product/new_product_page.dart	0.00%	2 Missing ⚠️
...ages/product/reorderable_knowledge_panel_page.dart	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #4890      +/-   ##
==========================================
- Coverage     9.62%   9.56%   -0.06%     
==========================================
  Files          323     328       +5     
  Lines        16267   16366      +99     
==========================================
  Hits          1565    1565              
- Misses       14702   14801      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[teolemon]

Hey @monsieurtanuki :-)

• the PR is a good start
• as was mentioned in the tracker issue for the PoC implementation, it should eventually rely on server side evolutions (issue there: New knowledge panels properties: half size panel + very short title and description openfoodfacts-server#9368 mentioned in Integrate the new product page #4842 )
• So we can expect some further refactoring so that the server can trigger this layout, including for the environment page
• there are some other issues that rely on server side changes (server side issues are listed). Please ensure to ping @stephanegigandet or @alexgarel before moving

[monsieurtanuki]

Thank you @teolemon for your comment!
I started this PR in order to check what was missing (cf. my comments in the OP) and to begin somehow.
If we're waiting for all the stars to align before doing anything we may wait way too long. Another added value of starting a bit early is to fuel the needs for features (instead of saying "btw some day we'll need this and that").
In the same spirit, if this PR is merged, we'll have a good reason to implement the tabs.

[monsieurtanuki]

I created this PR one month ago and there's not much activity around it.
Feel free to close it if after all it's not relevant. You may approve it too :)

[teolemon]

@g123k @monsieurtanuki We discussed the square layout yesterday in the Product Opener call. John is going to work on it, we made the necessary decision, and hopefully it will arrive soon.
We also felt it was necessary to uncouple the a11y decision, although we discussed it along the way. There are several options (smileys, thumbs up and down, or simply unambiguous text) and there's no agreement on it. We also want to bring the website on the same level.

[monsieurtanuki]

Closing as stale.