fix: contribution tag not highlighting as part of issue #10061 #10062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Product Page
Template::Toolkit
himanshisrestha
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10062 +/- ##
==========================================
+ Coverage 49.54% 49.58% +0.03%
==========================================
Files 67 70 +3
Lines 20650 20933 +283
Branches 4980 5019 +39
==========================================
+ Hits 10231 10379 +148
- Misses 9131 9264 +133
- Partials 1288 1290 +2 ☔ View full report in Codecov by Sentry. |
Thanks a lot 😃 |
john-gom
pushed a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The contribution tag in the navigation bar does not get highlighted even when on the page which has a contribution panel .
This issue was solved from the product_page.tt.html file where there was an anchor tag with the id="contribution" that was always being rendered on the product page even if the contribution_card_panel exists or not. I added the id="contribution" to the section tag containing the contribution panel and checked for the existence of the panel, if not the anchor tag with id="contribution" will be rendered.
Screenshot
fix-contri.mov
Related issue(s) and discussion