Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Knowledge panel to report a product on Signal Conso (France) #10092

Closed
wants to merge 5 commits into from
Closed

feat: Knowledge panel to report a product on Signal Conso (France) #10092

wants to merge 5 commits into from

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Apr 5, 2024 •
edited
Loading

What

feat: Knowledge panel to report a product on Signal Conso (France)

  • Currently not working
  • we're dropping the image to have a standard knowledge panel button
  • deadline: April 10th deployed
  • add UTM to the link so that DGCCRF can track impact

Screenshot

Related issue(s) and discussion

@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Apr 5, 2024
@teolemon
Copy link
Member Author

teolemon commented Apr 5, 2024

b/ProductOpener/KnowledgePanels.pm: Input file length is 57672 chars
lib/ProductOpener/KnowledgePanels.pm: Output file length is 57671 chars
lib/ProductOpener/KnowledgePanels.pm: Files first differ at character 0 of line 1608
lib/ProductOpener/KnowledgePanels.pm: 1606:}
lib/ProductOpener/KnowledgePanels.pm: <1608:
lib/ProductOpener/KnowledgePanels.pm: >1608:=head2 create_productreport_panel ( $product_ref, $target_lc, $target_cc...
lib/ProductOpener/KnowledgePanels.pm: ^
lib/ProductOpener/KnowledgePanels.pm:
make: *** [Makefile:367: check_perltidy] Error 2

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet
Copy link
Contributor

New PR: #10106

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 8, 2024
@stephanegigandet
Copy link
Contributor

Replaced with #10106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@teolemon teolemon

Labels
🇫🇷 France 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 💥 Merge Conflicts 💥 Merge Conflicts Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌐 Translations
Projects
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the SignalConso experiment
2 participants
@teolemon @stephanegigandet