Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: packaging adds Luxembourg #10570

Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat: packaging adds Luxembourg #10570

merged 2 commits into from
Jul 25, 2024

Conversation

benbenben2
Copy link
Collaborator

What

packaging codes adds Luxembourg

Screenshot

BEFORE -> AFTER
Screenshot_20240719_172512

Related issue(s) and discussion

Part of #338

More examples: #8921, #8958, #10264, #10318, #10351, #10388, #10485, #10533:

  • lib/ProductOpener/Display.pm
    add description (name, street, city) based on columns in the file or hardcoded
  • lib/ProductOpener/PackagerCodes.pm
    add country and suffix of the code
  • scripts/update_packager_codes.pl
    add code formatting ('country' 'code' 'suffix', for example if code does not already contain 'country' or 'suffix')
    add the column name for the $code variable
  • packager-codes/
    add the csv file (mind the naming)
  • scripts/packager-codes/
    add your script
  • update sto files
docker exec -it po_off-backend-1 bash
./scripts/update_packager_codes.pl

Fixes: #331

@benbenben2 benbenben2 added 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- 🇱🇺 Luxembourg labels Jul 19, 2024
@benbenben2 benbenben2 self-assigned this Jul 19, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner July 19, 2024 15:28
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benbenben2 :-)

@alexgarel
Copy link
Member

@benbenben2 you need a make lint_perltidy !

@benbenben2
Copy link
Collaborator Author

/lint

Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@benbenben2 benbenben2 merged commit bf87428 into main Jul 25, 2024
11 of 12 checks passed
@benbenben2 benbenben2 deleted the packaging_add_luxembourg branch July 25, 2024 20:05
stephanegigandet pushed a commit that referenced this pull request Jul 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.39.0](v2.38.1...v2.39.0)
(2024-07-30)


### Features

* add improvement to product navbar
([#10599](#10599))
([b812f72](b812f72))
* Display off days banner if donation banner was hidden
([#10566](#10566))
([5107f3e](5107f3e))
* duplicate script for off database
([#10583](#10583))
([de58db0](de58db0))
* packaging adds Luxembourg
([#10570](#10570))
([bf87428](bf87428)),
closes
[#331](#331)


### Bug Fixes

* disable log buffering and add more requests stats
([#10622](#10622))
([000ead2](000ead2))
* routing for group by tag in English (e.g es.openfoodfacts.org/in…
([#10618](#10618))
([574d600](574d600))
* utf8 decoding of off-query JSON
([#10617](#10617))
([a68de92](a68de92))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Display 🇱🇺 Luxembourg 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near-
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load packaging codes for Luxembourg
2 participants