-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added a geoip api endpoint #10648
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10648 +/- ##
==========================================
- Coverage 49.54% 49.33% -0.21%
==========================================
Files 67 77 +10
Lines 20650 22009 +1359
Branches 4980 5254 +274
==========================================
+ Hits 10231 10859 +628
- Misses 9131 9825 +694
- Partials 1288 1325 +37 ☔ View full report in Codecov by Sentry. |
|
@4nt0ineB what is the need for the GeoIP endpoint? Who is going to use it? Is it only for internal use (if so, which project?). |
There's a link to the issue: #10594 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -384,6 +385,43 @@ Reference to the request object. | |||
|
|||
=cut | |||
|
|||
# Dipatch table for API actions | |||
my $dispatch_table = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor 👍
What
Screenshot
Related issue(s) and discussion