fix: attribute for product without new nutriscore data #10915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Attributes
|
"make check_critic" passes locally, no clue why it fails on github... |
|
alexgarel
approved these changes
Oct 23, 2024
stephanegigandet
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [2.47.0](v2.46.0...v2.47.0) (2024-10-24) ### Features * api docs remove query string from get by barcode and add security to solve openapi linter errors/warnings ([#10922](#10922)) ([b7aefbd](b7aefbd)) * Eco-Score improvements and change of scale: A+ to F ([#10829](#10829)) ([87df665](87df665)) ### Bug Fixes * add googleOther bot ([#10912](#10912)) ([d56760a](d56760a)) * allow CORS requests for product image move ([#10920](#10920)) ([967a47e](967a47e)) * attribute for product without new nutriscore data ([#10915](#10915)) ([c413719](c413719)) * cosmetic changes for new Eco-Score grades ([#10921](#10921)) ([6e7dbfa](6e7dbfa)) * Revert "fix: remove unused jquery-ui safe-active-element module ([#10708](#10708))" ([#10924](#10924)) ([d290c54](d290c54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some products (in the obsolete collection) do not have new Nutri-Score data (but may have data in an older format). In that case the attribute Nutri-Score should be unknown. This can also happen if we display an older revision of a product.
I'll also recompute the Nutri-Score for the current revision of obsolete products.
Fixes openfoodfacts/smooth-app#5699