fix: Revert "fix: remove unused jquery-ui safe-active-element module (#10708)" #10924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…foodfacts#10708)" This reverts commit 9407e86.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10924 +/- ##
==========================================
- Coverage 49.54% 49.07% -0.48%
==========================================
Files 67 77 +10
Lines 20650 22215 +1565
Branches 4980 5310 +330
==========================================
+ Hits 10231 10901 +670
- Misses 9131 9980 +849
- Partials 1288 1334 +46 ☔ View full report in Codecov by Sentry. |
stephanegigandet
approved these changes
Oct 23, 2024
|
Thanks @stephanegigandet! |
jayaddison
deleted the
issue-10861/js-restore-safe-active-element-module
branch
stephanegigandet
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [2.47.0](v2.46.0...v2.47.0) (2024-10-24) ### Features * api docs remove query string from get by barcode and add security to solve openapi linter errors/warnings ([#10922](#10922)) ([b7aefbd](b7aefbd)) * Eco-Score improvements and change of scale: A+ to F ([#10829](#10829)) ([87df665](87df665)) ### Bug Fixes * add googleOther bot ([#10912](#10912)) ([d56760a](d56760a)) * allow CORS requests for product image move ([#10920](#10920)) ([967a47e](967a47e)) * attribute for product without new nutriscore data ([#10915](#10915)) ([c413719](c413719)) * cosmetic changes for new Eco-Score grades ([#10921](#10921)) ([6e7dbfa](6e7dbfa)) * Revert "fix: remove unused jquery-ui safe-active-element module ([#10708](#10708))" ([#10924](#10924)) ([d290c54](d290c54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9407e86.
What
After replicating the nutrient autosuggest selection problem (one of a few JavaScript-related problems) described in #10861 in a local development instance, I attempted a revert of #10708 because the name of the dependency seems similar to a missing function that appeared in the JavaScript console as an error:
After reverting #10708, the error no longer appears and I'm able to select entries from the nutrient autosuggest as expected.
Screenshot
pr-10708-revert-testing.mp4
Related issue(s) and discussion