Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better display of Eco-Score details #10934

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: better display of Eco-Score details #10934

merged 1 commit into from
Oct 25, 2024

Conversation

stephanegigandet
Copy link
Contributor

Small fixes:

  • correctly display the details of the origins of ingredients adjustment when origins and/or country of request is unknown / world.
  • remove extra comma causing an extra bar in the Eco-Score distribution graph
  • display a score of 0 when the score is negative

@stephanegigandet stephanegigandet requested a review from a team as a code owner October 25, 2024 11:01
@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products Display 🧪 integration tests labels Oct 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet stephanegigandet merged commit 19c70ed into main Oct 25, 2024
13 checks passed
@stephanegigandet stephanegigandet deleted the ecoscore4 branch October 25, 2024 12:21
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Display 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
📖 Knowledge panels
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @teolemon