Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: synonyms, stop-words, extended json exports #10951

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

McCio
Copy link
Contributor

@McCio McCio commented Oct 29, 2024

Taxonomies improvements

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧽 Data quality https://wiki.openfoodfacts.org/Quality GitHub Actions Pull requests that update Github_actions code 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. Tags 🥗 Ingredients labels Oct 29, 2024
@McCio McCio force-pushed the fix/taxonomies-extended branch 2 times, most recently from e455546 to 563bc7a Compare October 29, 2024 23:49
@McCio McCio marked this pull request as ready for review October 29, 2024 23:51
@McCio McCio requested a review from a team as a code owner October 29, 2024 23:51
@McCio McCio force-pushed the fix/taxonomies-extended branch 2 times, most recently from 7f53dee to 09cb979 Compare October 29, 2024 23:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.04%. Comparing base (dc04d18) to head (d969838).
Report is 728 commits behind head on main.

Files with missing lines Patch % Lines
lib/ProductOpener/Tags.pm 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10951      +/-   ##
==========================================
- Coverage   49.54%   49.04%   -0.51%     
==========================================
  Files          67       77      +10     
  Lines       20650    22237    +1587     
  Branches     4980     5315     +335     
==========================================
+ Hits        10231    10906     +675     
- Misses       9131     9998     +867     
- Partials     1288     1333      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 36516d8 into openfoodfacts:main Oct 30, 2024
12 checks passed
@McCio McCio deleted the fix/taxonomies-extended branch October 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality GitHub Actions Pull requests that update Github_actions code 🥗 Ingredients 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Tags 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants