ci: cache taxonomies in pr workflow #10952
Conversation
github-actions
bot
added
🧬 Taxonomies
McCio
force-pushed
the
ci/taxonomies-cache
branch
5 times, most recently
from
08c9635
to
0827b10
Compare
McCio
force-pushed
the
ci/taxonomies-cache
branch
from
0827b10
to
3ecf37e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10952 +/- ##
==========================================
- Coverage 49.54% 49.04% -0.51%
==========================================
Files 67 77 +10
Lines 20650 22237 +1587
Branches 4980 5315 +335
==========================================
+ Hits 10231 10906 +675
- Misses 9131 9998 +867
- Partials 1288 1333 +45 ☔ View full report in Codecov by Sentry. |
|
@alexgarel @stephanegigandet as I noted on slack some time ago, currently the github cache is not used during builds - with this PR I'm using the standard cache from github actions (with a bit of a hack copy/pasting from/to the build_cache volume). The downpoint is that it isn't usable for local development, as far as I know. |
.github/workflows/pull_request.yml
Outdated
| name: Prepare build_cache volumes | ||
| run: | | ||
| proj=po_off | ||
| docker volume create \ |
There was a problem hiding this comment.
Would it be possible to use something like --opt device=./build-cache, i.e. mount the folder directly, to avoid having to copy files to and from the docker volume?
There was a problem hiding this comment.
Didn't know about that, it seems way better! Will try it
.github/workflows/pull_request.yml
Outdated
| - if: steps.cache.outputs.cache-hit == 'true' | ||
| name: Prepare build_cache volumes | ||
| run: | | ||
| proj=po_off |
There was a problem hiding this comment.
It might be better to move the volume creation into the Makefile so that the existing COMPOSE_PROJECT_NAME variable can be used
There was a problem hiding this comment.
interesting, I'll look into that
| - name: Download backend image from artifacts | ||
| uses: ishworkh/docker-image-artifact-download@v1 | ||
| uses: ishworkh/container-image-artifact-download@v2.0.0 |
There was a problem hiding this comment.
Is this needed for this particular change or is it just a general version update?
There was a problem hiding this comment.
Kinda: it's just a general version update, as I was originally searching for a ready-to-use action to do the same with docker volume, I noticed that version is deprecated and is using the old github action to upload artifacts.
Updating it I noticed it's a bit faster than the old one, so I left it
McCio
force-pushed
the
ci/taxonomies-cache
branch
2 times, most recently
from
558750e
to
c77fdd7
Compare
McCio
force-pushed
the
ci/taxonomies-cache
branch
from
c77fdd7
to
f28dabe
Compare
|
cache taxonomies in pr workflow