Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump jquery-ui from 1.13.3 to 1.14.1 in the jquery group across 1 directory #10970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps the jquery group with 1 update in the / directory: jquery-ui.

Updates jquery-ui from 1.13.3 to 1.14.1

Release notes

Sourced from jquery-ui's releases.

jQuery UI 1.14.1 released

https://blog.jqueryui.com/2024/10/jquery-ui-1-14-1-released/

jQuery UI 1.14.0 released

https://blog.jqueryui.com/2024/08/jquery-ui-1-14-0-released/

Commits
  • ca5af71 1.14.1
  • bf0d4c3 Docs: Update AUTHORS.txt
  • 3bb4232 Build: Update a few dependencies, drop grunt-cli
  • d591bdd Widget: Don't let widget name affect $.ui prototype & constructor
  • 85bed8d Build: Fix an XSS in the test server HTML serving logic
  • af8adca Tabs: Use CSS.escape for sanitizing selectors
  • ebdcd0d Tests: Fix titles of jquery-patch.js tests
  • e399092 Build: Add a CodeQL non-mandatory check
  • 49bb397 Build: Fix the ESLint config for demos
  • 3934c68 Build: Bump express from 4.19.2 to 4.20.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner November 4, 2024 10:20
@dependabot dependabot bot added dependencies Pull requests that update a dependency file JavaScript labels Nov 4, 2024
@jayaddison
Copy link
Contributor

⚠️ Adding the same caution here as previously mentioned in #10891:

NB: please do not merge this until we have figured out a longer-term fix for #10861 -- otherwise repeating this upgrade may cause that to happen again.

After reading #2675.. unless anybody else would like to, or would recommend not doing this: I can spend some time to investigate replacing autocomplete and tagsInput with select2 (I have some experience with select2 as a user and also as a contributor). If possible, that would help towards completely removing jquery-ui; a smaller task than updating our Foundation-related dependencies.

cc @CharlesNepote @Valimp @hangy @raphael0202

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch from 94f46e6 to 5193941 Compare November 11, 2024 10:08
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch from 5193941 to abc7e54 Compare November 18, 2024 10:58
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch from abc7e54 to 6402f57 Compare November 25, 2024 12:21
@jayaddison
Copy link
Contributor

I've begun investigating replacement of jquery-ui autosuggest for nutriments entry with select2 -- so far I've noticed that select2 is used elsewhere on the same page already (for some language selection dropdown menus) and observed that the nutriment names are declared as a JavaScript Array on the client-side, but I haven't made much progress apart from that yet.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch 2 times, most recently from 87368db to 5cef5f3 Compare December 9, 2024 11:05
@jayaddison
Copy link
Contributor

I ran into difficulties attempting a migration to select2; it was not as simple as I expected. I would like to unblock this upgrade, and so as mentioned in #javascript on Slack, I'm going to attempt and test an upgrade from jquery v2.1.4 to jquery v2.2.4 in the static resources. I am optimistic that that would allow this upgrade of jquery-ui to proceed.

@jayaddison
Copy link
Contributor

I've opened #11109 to unblock this upgrade. I've tested that the nutrition autosuggest continues to work (the first problem reported in #10861) and browsed a few pages successfully in my dev env, but will try to test more functionality, and would be glad for any help.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch from 5cef5f3 to 6f2b5e5 Compare December 16, 2024 11:20
@teolemon
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch 2 times, most recently from f4b7eeb to bca2e00 Compare December 23, 2024 10:48
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch from bca2e00 to a91abe7 Compare December 30, 2024 10:41
Bumps the jquery group with 1 update in the / directory: [jquery-ui](https://github.com/jquery/jquery-ui).


Updates `jquery-ui` from 1.13.3 to 1.14.1
- [Release notes](https://github.com/jquery/jquery-ui/releases)
- [Commits](jquery/jquery-ui@1.13.3...1.14.1)

---
updated-dependencies:
- dependency-name: jquery-ui
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: jquery
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jquery-77c4060913 branch from a91abe7 to bb64911 Compare January 6, 2025 10:13
Copy link

sonarqubecloud bot commented Jan 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file JavaScript
Development

Successfully merging this pull request may close these issues.

2 participants