-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve edit button visibility #11037
base: main
Are you sure you want to change the base?
feat: Improve edit button visibility #11037
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11037 +/- ##
==========================================
- Coverage 49.54% 48.88% -0.66%
==========================================
Files 67 77 +10
Lines 20650 22283 +1633
Branches 4980 5339 +359
==========================================
+ Hits 10231 10893 +662
- Misses 9131 10057 +926
- Partials 1288 1333 +45 ☔ View full report in Codecov by Sentry. |
@davisjrule first a great thank you to bring your contribution to this project, I'm sorry for the latency in the review process… As you changed the file, your editor maybe, linted it, which makes it very hard to understand your changes. |
Also, as you modify the HTML, some test outputs will change so you need to run "make update_tests_results" |
Quality Gate passedIssues Measures |
@davisjrule are you willing to try to finish this PR following my comments above ? |
What
This pull request addresses issue [#10865] by improving the web user experience on the product page. Previously, the "Edit" and "Share" buttons were positioned at the top and bottom of the page. This placement required users to scroll back to those specific areas to access these actions, which could be inconvenient, especially on pages with extensive product information.
Changes Made:
Moved "Edit" and "Share" Buttons to Navbar:
product_page.tt.html
template to include the "Edit" and "Share" buttons within the navbar's inline list.Adjusted HTML Structure:
<li>
elements within the existing<ul class="inline-list">
in the navbar.Removed Redundant "Edit" Button at Bottom:
Why These Changes Were Made:
Enhanced Usability:
Consistency Across Pages:
Screenshot
Related issue(s) and discussion