Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Mozartkugeln #11084

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

taxonomy: Mozartkugeln #11084

wants to merge 6 commits into from

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Dec 2, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 4, 2024
@stephanegigandet stephanegigandet changed the title german Mozartkugeln taxonomy: german Mozartkugeln Dec 4, 2024
@teolemon teolemon added the Austria https://wiki.openfoodfacts.org/Local_Communities/GermanTeam label Dec 4, 2024
@moon-rabbitOFF moon-rabbitOFF changed the title taxonomy: german Mozartkugeln taxonomy: Mozartkugeln Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.03%. Comparing base (ac175ce) to head (94a55f2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11084      +/-   ##
==========================================
+ Coverage   40.64%   49.03%   +8.38%     
==========================================
  Files          77       78       +1     
  Lines       22316    22374      +58     
  Branches     5354     5363       +9     
==========================================
+ Hits         9071    10971    +1900     
+ Misses      12067    10058    -2009     
- Partials     1178     1345     +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -41476,6 +41481,11 @@ ciqual_food_code:en: 53503
ciqual_food_name:en: Yam or Indian potato, peeled, boiled/cooked in water
ciqual_food_name:fr: Igname, épluchée, bouillie/cuite à l'eau

< en:Cereals and potatoes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taxonomy wise, Klöse can be potato, meat (Fleischklöße), Quark (Topfenknödel), wheat (Hefeknödel) based, and more. Based on https://de.wikipedia.org/w/index.php?title=Klo%C3%9F&oldid=248171204#Varianten, putting all of them under the potato/cereal parent category sounds a bit inaccurate

Comment on lines +69672 to +69675
< en:Dried fruits
en: Dried cherries
fr: Cerises séchées

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary because dried/sechees are already in ingredients_processing taxonom. Hence, dried cherries and cerises sechees should be recognized ingredients already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Austria https://wiki.openfoodfacts.org/Local_Communities/GermanTeam categories ⭐ top pull request Top pull request. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants