Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Add missing ingredients from mymuesli #11185

Merged

Conversation

github-throwaway
Copy link
Contributor

@github-throwaway github-throwaway commented Jan 3, 2025

What

Add missing ingredients from mymuesli product

@github-throwaway github-throwaway changed the title Add missing ingredients for 'Glutenfree Chocolate Müsli' from mymuesli taxonomy: Add missing ingredients from mymuesli Jan 3, 2025
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (bf82a79) to head (e381285).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11185   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files          78       78           
  Lines       22371    22371           
  Branches     5365     5365           
=======================================
  Hits        11019    11019           
  Misses       9996     9996           
  Partials     1356     1356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aleene aleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better comment out the compound parent. It is not yet official.

Copy link

sonarqubecloud bot commented Jan 5, 2025

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-throwaway
Copy link
Contributor Author

@aleene Is there anything still missing or are we good to merge this? :) Also, which update method is preferred? Update with merge commit or Update with rebase?

@aleene aleene merged commit 16acef0 into openfoodfacts:main Jan 6, 2025
15 checks passed
@github-throwaway github-throwaway deleted the github-throwaway-mymuesli branch January 6, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants