feat: petfood-nutrition-facts

[benbenben2]

What

Based on EU regulations:
https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX%3A02009R0767-20181226&qid=1734788661215

Nutrition for pet food products is somewhat different than for human food.

There are 3 types of nutriments in pet food nutrition facts

• analytical constituents -> always in %
• nutritional additives -> in mg/kg or UI/kg (i.e. not per 100g)
• zootechnical additives -> in mg/kg

Suggested solution is to use existing nutrition tables as defined in Food.pm (see %nutriments_tables) but split into 2 off_ and opff_.
A few if petfood ... else ... have been introduced. Another option might have been to make it more generic and use setup in ProductsFeatures, but that would have been more complex.

There might be future minor improvements (for the future) such as:

• vitamin for pet food is in UI and not mg (for now contributors can change)
• iron II sulphate monohydrate and iron might be used interchangably for pet food. i.e. iron for pet food might not be same as iron for food.
• crude-protein for pet food might or might not be identical to protein for food. Same for crude-fibre and fibre

Since the nutriments not given in % are given in mg/kg, nutriments suffix can be _1kg and not only _100g (see screenshot of the API below). Also compute_nutrition_data_per_100g_and_per_serving is renamed compute_nutrition_data_per_xxg_and_per_serving,

Fixes:

• fixed bug pet_food -> petfood (x2)
• fixed warning in API.pm

comment:
There is a bit of confusion in variables naming because product_type is used for both
- flavor product type (petfood, food, beauty, products)
- nutrition fact quantity/measurement type like in foreach my $product_type ("", "_prepared") {

Screenshot

BEFORE

AFTER

Related issue(s) and discussion

• Fixes #-none-

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.

Project coverage is 49.14%. Comparing base (765d796) to head (c12efba).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/ProductOpener/Display.pm	0.00%	18 Missing ⚠️
lib/ProductOpener/Food.pm	0.00%	3 Missing and 1 partial ⚠️
lib/ProductOpener/API.pm	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11188      +/-   ##
==========================================
- Coverage   49.18%   49.14%   -0.04%     
==========================================
  Files          78       78              
  Lines       22389    22404      +15     
  Branches     5371     5378       +7     
==========================================
  Hits        11011    11011              
- Misses      10020    10034      +14     
- Partials     1358     1359       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benbenben2]

/update_tests_results

[stephanegigandet]

@benbenben2 awesome work! Thank a lot for looking into this!

I'm a bit wary of adding the _1kg suffix. I think an alternative would be to keep the _100g internally, so that we can keep the code closer to the food code. Maybe we could discuss it in the product opener meeting, or in another call?

[benbenben2]

@benbenben2 awesome work! Thank a lot for looking into this!

I'm a bit wary of adding the _1kg suffix. I think an alternative would be to keep the _100g internally, so that we can keep the code closer to the food code. Maybe we could discuss it in the product opener meeting, or in another call?

front for product as well as for edit remains per 1 kg. API is rolled back to be per 100g. There is changes in Food and Display to switch from front to api (divide by 10) and from api to front (multiply by 10), respectively.

function name is rolled back from xxg to 100g

[benbenben2]

/lint

[benbenben2]

/lint

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud