-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Add Canadian front-of-package nutrition symbol #11284
base: main
Are you sure you want to change the base?
taxonomy: Add Canadian front-of-package nutrition symbol #11284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11284 +/- ##
==========================================
- Coverage 49.33% 49.32% -0.01%
==========================================
Files 79 80 +1
Lines 22510 22575 +65
Branches 5387 5397 +10
==========================================
+ Hits 11105 11135 +30
- Misses 10045 10085 +40
+ Partials 1360 1355 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me, but another review would be useful: @aleene @stephanegigandet ?
Co-authored-by: Charles Nepote <[email protected]>
I noticed that these are svg files. Is this allowed? Especially for integration with Hunger games? |
Stephane told me to convert the |
|
…github.com/github-throwaway/openfoodfacts-server into github-throwaway_add_canadian_health_label
Changes have been made. Thoughts? |
Hi @github-throwaway , thanks for adding the logos! I suggest that we keep only the horizontal version, with the 3 language variations logos in each of the 7 entries: < en:Canadian front-of-package nutrition symbol So that would be only 7 entries, + the parent entry. Label name would be exactly the text shown on logo, and the file name matches the label name. If we do it this way, then we will display the English logo on the English site, the French logo on the French site, and the English+French logo for other languages, as Charles suggested. |
@stephanegigandet Is there a special reason why in the checks the linter does not apply the fixes automatically? |
Quality Gate passedIssues Measures |
What
Add font-of-package nutrition symbol from Health Canada.
There is probably a better naming convention for the 56 label variations. But this is a start. Happy for any feedback.
Related issue(s) and discussion