Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make some images aware of dark mode #3911

Closed
wants to merge 5 commits into from
Closed

feat: Make some images aware of dark mode #3911

wants to merge 5 commits into from

Conversation

hangy
Copy link
Member

@hangy hangy commented Jul 21, 2020 •
edited by teolemon
Loading

@hangy hangy self-assigned this Jul 21, 2020
@hangy
Copy link
Member Author

hangy commented Jul 21, 2020 •
edited
Loading

The product silhouette and English OFF icon already work quite well. I'll look into updating the other icons, and fixing the translations to include SVGs where possible.

We should also look into removing redundant SVGs in the html/images/misc and html/images/svg directories.

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon
Copy link
Member

How about keeping both versions with different names ? Although the color can be changed programmatically, having light and dark versions would also be useful for marketing purposes.

This was referenced Aug 21, 2021
Open
Open
@teolemon teolemon changed the title Make some image aware of dark mode feat: Make some images aware of dark mode Jan 22, 2022
@CloCkWeRX
Copy link
Contributor

@hangy did you feel like this could be mergable in its current form? Any chance you'd adopt or improve the android SVG logo on #3317 (comment) into this PR?

@hangy hangy closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hangy hangy

Labels
Dark mode 🎨 Design logos
Projects
🍊 Open Food Facts Server issues
Archived in project
🎨 UXR & Design team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hangy @teolemon @CloCkWeRX