Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rename 'Validate' -> 'Resize' #5611

Closed
wants to merge 1 commit into from
Closed

fix: Rename 'Validate' -> 'Resize' #5611

wants to merge 1 commit into from

Conversation

blazern
Copy link
Contributor

@blazern blazern commented Sep 5, 2021 •
edited by teolemon
Loading

Note: all I did was a global search and replace. I have know idea of whether I'm breaking anything.

Changes according to this dialog: https://openfoodfacts.slack.com/archives/C02KVRT2C/p1630762333049300?thread_ts=1630741111.048400&cid=C02KVRT2C
image

Part of

@blazern blazern requested a review from a team as a code owner September 5, 2021 07:59
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet
Copy link
Contributor

So in fact we just need to change the file in /lang/en/texts + /po/common/common.pot , the rest will be translated by Crowdin, they should not be changed manually.

@teolemon teolemon added Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org ✏️ Editing ✏️ Editing - Images labels Sep 16, 2021
@blazern
Copy link
Contributor Author

blazern commented Oct 23, 2021

So in fact we just need to change the file in /lang/en/texts + /po/common/common.pot , the rest will be translated by Crowdin, they should not be changed manually.

oops I totally missed this message, sorry
will do

@blazern
Copy link
Contributor Author

blazern commented Oct 23, 2021

Done!

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blazern
Copy link
Contributor Author

blazern commented Oct 28, 2021

@stephanegigandet could you please take a look again?

@teolemon teolemon changed the title Rename 'Validate' -> 'Resize' fix: Rename 'Validate' -> 'Resize' Jan 22, 2022
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Feb 18, 2022
@openfoodfacts-bot openfoodfacts-bot deleted the validate-rename-to-resize branch October 3, 2023 16:04
@openfoodfacts-bot
Copy link
Contributor

@blazern we have moved those to lhttps://github.com/openfoodfacts/openfoodfacts-web

ang/en/texts/how-to-add-a-product.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaiTon VaiTon VaiTon approved these changes

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

Assignees

@blazern blazern

Labels
✏️ Editing - Images ✏️ Editing 💥 Merge Conflicts 💥 Merge Conflicts Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blazern @stephanegigandet @openfoodfacts-bot @VaiTon @teolemon