Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make panel ids consistent for ingredients analysis knowledge panels #6815

Merged
merged 2 commits into from
May 30, 2022
Merged

fix: make panel ids consistent for ingredients analysis knowledge panels #6815

merged 2 commits into from
May 30, 2022

Conversation

stephanegigandet
Copy link
Contributor

Fixes #6810

  • Panel ids for ingredients analysis properties are now all in this format: ingredients_analysis_[value of the ingredients_analysis_tag]
    e.g. ingredients_analysis_en:may-contain-palm-oil
  • Attributes link to the same panel ids
  • On the website interface, some elements ids include the panel id (to create links). The : character is replaced by -.

@stephanegigandet stephanegigandet added the 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels label May 23, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner May 23, 2022 15:59
@github-actions github-actions bot added the Attributes https://wiki.openfoodfacts.org/Product_Attributes label May 23, 2022
teolemon
teolemon approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💚 Thank you very much

alexgarel
alexgarel approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have two comments.

html/js/product-search.js Show resolved Hide resolved
lib/ProductOpener/Attributes.pm Show resolved Hide resolved
@stephanegigandet stephanegigandet mentioned this pull request May 25, 2022
Open
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit 726fb92 into main May 30, 2022
@stephanegigandet stephanegigandet deleted the ingredients-analysis-panels branch May 30, 2022 12:15
@alexgarel alexgarel mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Attributes https://wiki.openfoodfacts.org/Product_Attributes 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🧪 tests
Projects
🍊 Open Food Facts Server issues
Archived in project
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistant normalization prevents linked knowledge panels from working
3 participants
@stephanegigandet @alexgarel @teolemon