Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add UTM to the login page donation promo #7719

Merged
merged 2 commits into from
Nov 25, 2022
Merged

fix: add UTM to the login page donation promo #7719

merged 2 commits into from
Nov 25, 2022

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Nov 17, 2022 •
edited
Loading

What

fix: add UTM to the login page donation promo

Part of

@teolemon teolemon requested a review from a team as a code owner November 17, 2022 21:10
@github-actions github-actions bot added the Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org label Nov 17, 2022
stephanegigandet
stephanegigandet reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only en.po and not common.pot?

@teolemon teolemon marked this pull request as draft November 18, 2022 08:52
@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon marked this pull request as ready for review November 22, 2022 13:15
@teolemon
Copy link
Member Author

fixed @stephanegigandet

@stephanegigandet stephanegigandet merged commit f2812b8 into main Nov 25, 2022
@stephanegigandet stephanegigandet deleted the utm-login-page branch November 25, 2022 08:47
@alexgarel alexgarel mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@teolemon teolemon

Labels
🎁 donations Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teolemon @stephanegigandet