feat: Allow scanning more GS1 barcodes #8911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8911 +/- ##
==========================================
+ Coverage 46.09% 46.32% +0.23%
==========================================
Files 64 64
Lines 19837 19897 +60
Branches 4801 4810 +9
==========================================
+ Hits 9143 9217 +74
+ Misses 9513 9501 -12
+ Partials 1181 1179 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Currently missing: |
teolemon
added
the
GS1
|
@hangy We're having the Product Opener call in 20 minutes if you'd like to present the PR >>> https://meet.google.com/nnw-qswu-hza |
hangy
commented
Aug 28, 2023
hangy
force-pushed
the
issue/8333-gs1-sunrise-2027
branch
from
7ba9537 to
fdb84b7
Compare
- Remove redundant `$` - Fix scope of `$ai_data_str` - Some regexes
- libzxing-dev requires a the current Debian stable, bookworm. - libapache2-request-perl is only available via backports for bookworm.
test: Add first unittest for GS1 DataMatrix code Thanks to @tonycoz (TONYC on cpan) for implementing Imager::zxing!
- Ensure that more GS1 Data Link URI formats can be 'normalized' - URIs that cannot be a GS1 Data Link should not be treated as an product code
hangy
added a commit
that referenced
this pull request
Sep 11, 2023
hangy
force-pushed
the
issue/8333-gs1-sunrise-2027
branch
2 times, most recently
from
fc27db2 to
074b1cc
Compare
hangy
force-pushed
the
issue/8333-gs1-sunrise-2027
branch
from
074b1cc to
16ebb60
Compare
hangy
added a commit
that referenced
this pull request
Sep 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
hangy
added a commit
that referenced
this pull request
Sep 21, 2023
hangy
added a commit
that referenced
this pull request
Nov 29, 2023
* chg: Support GS1 barcodes for code normalization * fix: Minor mistakes - Remove redundant `$` - Fix scope of `$ai_data_str` - Some regexes * fix: perl tidy and critic * test: Add additional test for normalization * chg: Catch GS1::SyntaxEngine exceptions * test: Some more cases * fix: Don't try to normalize undef code * test: Add additional tests for `normalize_code` - Ensure that more GS1 Data Link URI formats can be 'normalized' - URIs that cannot be a GS1 Data Link should not be treated as an product code * docs: Update POD for `normalize_code()` * fix: URI and URL should both be valid in code * test: Add some image test [WIP] * test: Some more cases * deps(cpan): Add Imager::zxing to support DataMatrix barcodes - libzxing-dev requires a the current Debian stable, bookworm. - libapache2-request-perl is only available via backports for bookworm. * feat: Use Imager::zxing to decode DataMatrix codes test: Add first unittest for GS1 DataMatrix code Thanks to @tonycoz (TONYC on cpan) for implementing Imager::zxing! * test: Add tests for GS1 Data URI with QR Code and DataMatrix * test: Add tests for some GS1 DataBar variants * deps: Revert to debian bullseye, and install zxing-cpp 2.1.0 manually See #8911 (comment) for discussion * style: Fix indentation --------- Co-authored-by: Alex Garel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use the official GS1 parser library to extract more types of barcodes from images, as to support the GS1 "Sunrise 2027" initiative.
Related issue(s) and discussion