feat: Use 'GS1 Barcode Syntax Engine' in READ API v3 #9050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant `$` - Fix scope of `$ai_data_str` - Some regexes
- Ensure that more GS1 Data Link URI formats can be 'normalized' - URIs that cannot be a GS1 Data Link should not be treated as an product code
Should possibly have a feature flag, depending on the API version
…rom the code to allow query params in GS1 data URI to be present
…nd `decodeURIComponent`, so that a '/' in the code isn't split.
…rd `gs1_ai_data_str`.
The dummy number used before does not have a valid checksum.
github-actions
bot
added
API
hangy
added
the
GS1
stephanegigandet
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Looks good, but since I merged in #9049 there's a slight merge conflict.
Thanks! Sorry about the conflict. I fixed it locally and pushed an update. |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #9050 +/- ##
==========================================
+ Coverage 46.31% 46.36% +0.04%
==========================================
Files 64 64
Lines 19916 19924 +8
Branches 4814 4815 +1
==========================================
+ Hits 9225 9238 +13
+ Misses 9523 9520 -3
+ Partials 1168 1166 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use Perl module
GS1::SyntaxEngine::FFIin READ API. This allows GS1 Data URI, AI Data String, and so on to be used in the URL.Related issue(s) and discussion