Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quantities starting with a dot .33L #9284

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: quantities starting with a dot .33L #9284

merged 3 commits into from
Nov 13, 2023

Conversation

stephanegigandet
Copy link
Contributor

fixes #9271

@stephanegigandet stephanegigandet requested a review from a team as a code owner November 10, 2023 13:20
@codecov-commenter
Copy link

Codecov Report

Merging #9284 (512e5b5) into main (2761f09) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9284   +/-   ##
=======================================
  Coverage   47.95%   47.95%           
=======================================
  Files          65       65           
  Lines       20277    20277           
  Branches     4914     4914           
=======================================
  Hits         9724     9724           
  Misses       9301     9301           
  Partials     1252     1252
Files Coverage Δ
lib/ProductOpener/Numbers.pm 100.00% <ø> (ø)
lib/ProductOpener/Units.pm 81.70% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

CharlesNepote
CharlesNepote approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I added two small suggestions. It's up to you.
Thanks a lot!

tests/unit/units.t Show resolved Hide resolved
tests/unit/units.t Show resolved Hide resolved
stephanegigandet and others added 2 commits November 10, 2023 15:22
@stephanegigandet @CharlesNepote
Update tests/unit/units.t
bcf96da 
Co-authored-by: Charles Nepote <[email protected]>
@stephanegigandet @CharlesNepote
Update tests/unit/units.t
f2e60e1 
Co-authored-by: Charles Nepote <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 5523a15 into main Nov 13, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the fix-dot-quantity branch November 13, 2023 09:25
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Nov 13, 2023
Merged
alexgarel pushed a commit that referenced this pull request Nov 21, 2023
@stephanegigandet @alexgarel
fix: quantities starting with a dot .33L (#9284)
8293a98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Numbers ⚖️ Quantity 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quantity: .33L is wrongly converted into 33000 grams
4 participants
@stephanegigandet @codecov-commenter @CharlesNepote @teolemon