Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug_ingredients_wrongly_specific_ingredients #9624

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

benbenben2
Copy link
Collaborator

What

Make sure that variables are 1) defined + 2) non equal to "", to detect specific ingredients

Screenshot

Screenshot_20240106_124229

Related issue(s) and discussion

@benbenben2 benbenben2 added 🐛 bug This is a bug, not a feature request. 🥗 Ingredients 🇵🇱 Polish https://pl.openfoodfacts.org/ labels Jan 6, 2024
@benbenben2 benbenben2 self-assigned this Jan 6, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner January 6, 2024 11:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d295d1) 49.29% compared to head (9807d38) 49.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9624   +/-   ##
=======================================
  Coverage   49.29%   49.29%           
=======================================
  Files          66       66           
  Lines       20551    20551           
  Branches     4949     4949           
=======================================
  Hits        10130    10130           
  Misses       9132     9132           
  Partials     1289     1289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @benbenben2 !

@stephanegigandet stephanegigandet merged commit 0426fd7 into main Jan 9, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the bug_ingredients_wrongly_specific_ingredients branch January 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ingredients wrongly parsed as specific ingredients
3 participants