Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Centralise all retrieval and storage of user information #9958

Merged
merged 15 commits into from
Mar 21, 2024
Merged

refactor: Centralise all retrieval and storage of user information #9958

merged 15 commits into from
Mar 21, 2024

Conversation

john-gom
Copy link
Contributor

@john-gom john-gom commented Mar 19, 2024 •
edited
Loading

Make sure you've done all the following

  • Include unit tests for new functionality
  • Code passes GitHub workflow checks in your branch
  • If you have multiple commits please combine them into one commit by squashing them.

What

Move all user storage and retrieval to a single place so it is easier to switch to fetching data from Keycloak

Related issue(s) and discussion

@john-gom john-gom requested a review from a team as a code owner March 19, 2024 13:44
@github-actions github-actions bot added 📚 Documentation Documentation issues improve the project for everyone. 🕹️ Gamification 🧪 tests 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Display 👥 Users 🔐 Password labels Mar 19, 2024
stephanegigandet
stephanegigandet approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@john-gom john-gom merged commit 303142f into main Mar 21, 2024
13 checks passed
@john-gom john-gom deleted the keycloak-users branch March 21, 2024 17:13
Payne680 pushed a commit to Payne680/openfoodfacts-server that referenced this pull request Mar 25, 2024
@john-gom @Mal-One
refactor: Centralise all retrieval and storage of user information (o…
785cd88 
…penfoodfacts#9958)

* Fix core user code

* CGI scripts

* Remove user from example

* Other libraries

* Script updates

* Delete obsolete scripts

* Fixmissed scripts

* Test query

* Lint fixes

* Fixes

* Fix typo

* More typos

* Perlcritic fixes
john-gom added a commit that referenced this pull request May 24, 2024
@john-gom
refactor: Centralise all retrieval and storage of user information (#…
f661f8d 
…9958)

* Fix core user code

* CGI scripts

* Remove user from example

* Other libraries

* Script updates

* Delete obsolete scripts

* Fixmissed scripts

* Test query

* Lint fixes

* Fixes

* Fix typo

* More typos

* Perlcritic fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@john-gom john-gom

Labels
Display 📚 Documentation Documentation issues improve the project for everyone. 🕹️ Gamification 🔐 Password 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🧪 tests 👥 Users
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-gom @teolemon @stephanegigandet