feat: implement real multi-platform support (OFF, OBF,...) #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
force-pushed
the
remove-server-domain
branch
from
eeb3a5c
to
035d5e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 53.06% 55.73% +2.66%
==========================================
Files 93 88 -5
Lines 7076 8089 +1013
==========================================
+ Hits 3755 4508 +753
- Misses 3321 3581 +260
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raphael0202
force-pushed
the
remove-server-domain
branch
from
035d5e7
to
36f5036
Compare
raphael0202
changed the title
- delete server_domain in image, product_insight and prediction tables - add server_type field to image and prediction tables - use ProductIdentifier (barcode + server_type) instead of barcode in codebase See #894
raphael0202
force-pushed
the
remove-server-domain
branch
from
36f5036
to
760eb05
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@raphael0202 BTW I did go through half of this PR but didn't have any comment… (and it was very boring to review 😄) Only worry on my side: you introduced new variables but did not add them in deployment workflow. Is it because you have sensible defaults ? |
|
I understand that, it was quite boring for me as well to implement 😅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in codebase
See #894