Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple triton backend #1314

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

raphael0202
Copy link
Collaborator

  • allow to run inference on a distinct Triton server
  • improve worker task dispatch
  • add a new CLI command to run category detection on the full DB

before, we had 2 high priority workers (that listened to queue high-1
and high-2 respectively), and 2 workers that listened both to one
high priority queue (high-3 or high-4) and to low priority queue.

It's beneficial that all workers listen to low priority queue (but with
a lower priority), so that low priority jobs get completed faster when
there is no high priority tasks.
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (cf12304) 57.53% compared to head (fe0c380) 57.33%.

Files Patch % Lines
robotoff/cli/main.py 7.69% 24 Missing ⚠️
robotoff/workers/tasks/product_updated.py 33.33% 6 Missing ⚠️
robotoff/prediction/object_detection/core.py 25.00% 3 Missing ⚠️
robotoff/triton.py 50.00% 3 Missing ⚠️
...y/neural/keras_category_classifier_3_0/__init__.py 50.00% 2 Missing ⚠️
robotoff/prediction/ingredient_list/__init__.py 33.33% 2 Missing ⚠️
robotoff/workers/tasks/import_image.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   57.53%   57.33%   -0.21%     
==========================================
  Files          79       79              
  Lines        7793     7835      +42     
==========================================
+ Hits         4484     4492       +8     
- Misses       3309     3343      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit a7eab33 into main Feb 13, 2024
8 of 10 checks passed
@raphael0202 raphael0202 deleted the add-multiple-triton-backend branch February 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant