fix: fix barcode filtering #1455
Merged
+79
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check that the brand was in the EAN barcode ranges for every brand prediction. However, it lead to too many false rejection. We now only check barcode range and brand blacklist for brands have the 'taxonomy' or 'curated-list' predictor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
+ Coverage 54.43% 54.53% +0.10%
==========================================
Files 85 85
Lines 8673 8673
==========================================
+ Hits 4721 4730 +9
+ Misses 3952 3943 -9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check that the brand was in the EAN barcode ranges for every brand prediction. However, it lead to too many false rejection. We now only check barcode range and brand blacklist for brands have the 'taxonomy' or 'curated-list' predictor.