-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added origin extraction #890
Changes from 10 commits
c65438d
e07cac9
bf7dc9f
b77360d
eeb2c64
bb64958
6bb5767
668d2fc
31f07e5
ccba94c
c142504
6d0af13
cc72baf
335e563
ee351bb
9806baa
6228811
64bf201
69c685d
8c48f12
433ae15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
# nice way to have our .env in environment for use in makefile | ||
# see https://lithic.tech/blog/2020-05/makefile-dot-env | ||
# Note: this will mask environment variable as opposed to docker-compose priority | ||
# Note: this will mask environment variable as opposed to docker compose priority | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why have you introduced these changes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same thing, I made that because on my computer for unknown reason the "docker compose" don't exists, I have to use "docker-compose". This should be removed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alright, can you revert to the original version? |
||
# yet most developper should'nt bump into this | ||
ifneq (,$(wildcard ./.env)) | ||
-include .env | ||
|
@@ -14,8 +14,8 @@ NAME = "robotoff" | |
ENV_FILE ?= .env | ||
MOUNT_POINT ?= /mnt | ||
HOSTS=127.0.0.1 robotoff.openfoodfacts.localhost | ||
DOCKER_COMPOSE=docker-compose --env-file=${ENV_FILE} | ||
DOCKER_COMPOSE_TEST=COMPOSE_PROJECT_NAME=robotoff_test PO_LOCAL_NET=po_test docker-compose --env-file=${ENV_FILE} | ||
DOCKER_COMPOSE=docker compose --env-file=${ENV_FILE} | ||
DOCKER_COMPOSE_TEST=COMPOSE_PROJECT_NAME=robotoff_test PO_LOCAL_NET=po_test docker compose --env-file=${ENV_FILE} | ||
|
||
.DEFAULT_GOAL := dev | ||
# avoid target corresponding to file names, to depends on them | ||
|
@@ -50,7 +50,7 @@ edit_etc_hosts: | |
# Docker Compose # | ||
#----------------# | ||
up: | ||
# creates a docker network and runs docker-compose | ||
# creates a docker network and runs docker compose | ||
@echo "🥫 Building and starting containers …" | ||
docker network create po_default || true | ||
${DOCKER_COMPOSE} up -d --build 2>&1 | ||
|
@@ -76,7 +76,7 @@ livecheck: | |
docker/docker-livecheck.sh | ||
|
||
log: | ||
@echo "🥫 Reading logs (docker-compose) …" | ||
@echo "🥫 Reading logs (docker compose) …" | ||
${DOCKER_COMPOSE} logs -f | ||
|
||
#------------# | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have you introduced these changes?