Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: robustness and localdev #906

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Sep 21, 2022

What

  • make some part of the code and settings more compliant to a use with a local deploy of product opener
  • settings had a dangerous pattern in the object to get domains, fixed it.
  • also made scheduler more resilient to not having network

Note: a more serious refactor of networks between docker should be done, but later...

This was done to be able to test openfoodfacts/openfoodfacts-server#7379

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #906 (aba99d5) into master (cdab35f) will increase coverage by 0.03%.
The diff coverage is 92.00%.

❗ Current head aba99d5 differs from pull request most recent head eff625d. Consider uploading reports for the commit eff625d to get more accurate results

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   52.80%   52.83%   +0.03%     
==========================================
  Files          92       92              
  Lines        7034     7045      +11     
==========================================
+ Hits         3714     3722       +8     
- Misses       3320     3323       +3     
Impacted Files Coverage Δ
robotoff/off.py 31.95% <0.00%> (-0.14%) ⬇️
robotoff/prediction/ocr/image_flag.py 41.02% <ø> (ø)
robotoff/scheduler/__init__.py 47.79% <66.66%> (+0.06%) ⬆️
robotoff/slack.py 91.33% <89.74%> (ø)
robotoff/app/api.py 49.30% <100.00%> (ø)
robotoff/app/core.py 91.86% <100.00%> (ø)
robotoff/settings.py 96.66% <100.00%> (+0.13%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 122 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication

.env Outdated Show resolved Hide resolved
Copy link
Collaborator

@raphael0202 raphael0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See attached comments

@alexgarel
Copy link
Member Author

I've done requested changes @raphael0202

@raphael0202 raphael0202 self-requested a review September 27, 2022 13:11
@raphael0202 raphael0202 merged commit ec380ab into master Sep 27, 2022
@raphael0202 raphael0202 deleted the refactor-robustness-localdev branch September 27, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants