Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update category matching algorithm #952

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Conversation

raphael0202
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #952 (c297f99) into master (3a5f9ab) will increase coverage by 0.17%.
The diff coverage is 64.45%.

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   53.06%   53.24%   +0.17%     
==========================================
  Files          93       86       -7     
  Lines        7076     6912     -164     
==========================================
- Hits         3755     3680      -75     
+ Misses       3321     3232      -89     
Impacted Files Coverage Δ
robotoff/cli/insights.py 0.00% <0.00%> (ø)
robotoff/elasticsearch/export.py 84.84% <ø> (-12.38%) ⬇️
robotoff/off.py 38.33% <0.00%> (+3.02%) ⬆️
...rediction/object_detection/utils/label_map_util.py 22.22% <0.00%> (ø)
...object_detection/utils/string_int_label_map_pb2.py 100.00% <ø> (ø)
robotoff/prediction/ocr/image_flag.py 41.02% <ø> (ø)
robotoff/prediction/ocr/label.py 72.30% <ø> (ø)
robotoff/products.py 42.75% <ø> (ø)
robotoff/utils/cache.py 95.45% <0.00%> (ø)
robotoff/cli/main.py 33.94% <16.66%> (-0.51%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael0202 raphael0202 requested a review from alexgarel October 12, 2022 14:20
@raphael0202 raphael0202 marked this pull request as ready for review October 12, 2022 14:20
@raphael0202 raphael0202 requested a review from a team as a code owner October 12, 2022 14:20
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea and implementation.

I have some comments, most are style, but some might be important.
However I approve and let you fix what you want to fix.

robotoff/app/api.py Outdated Show resolved Hide resolved
robotoff/app/api.py Outdated Show resolved Hide resolved
robotoff/utils/text.py Show resolved Hide resolved
robotoff/prediction/category/matcher.py Show resolved Hide resolved
robotoff/prediction/category/matcher.py Show resolved Hide resolved
robotoff/prediction/category/matcher.py Outdated Show resolved Hide resolved
robotoff/prediction/category/matcher.py Outdated Show resolved Hide resolved
robotoff/prediction/category/matcher.py Show resolved Hide resolved
robotoff/prediction/category/matcher.py Outdated Show resolved Hide resolved
robotoff/prediction/category/matcher.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 8 Security Hotspots
Code Smell A 140 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

@raphael0202 raphael0202 merged commit d8a04c7 into master Oct 18, 2022
@raphael0202 raphael0202 deleted the category-matching branch October 18, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants