In the case where the user is stuck with the message "Saving a local …

…version…", we will now send the error to the server
openfoodfacts · Jul 14, 2023 · 8ed7a1b · 8ed7a1b
1 parent 1cd22a6
commit 8ed7a1b
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/packages/smooth_app/lib/helpers/analytics_helper.dart b/packages/smooth_app/lib/helpers/analytics_helper.dart
@@ -324,6 +324,10 @@ class AnalyticsHelper {
     }
   }
 
+  static void sendException(dynamic throwable, {dynamic stackTrace}) {
+    Sentry.captureException(throwable, stackTrace: stackTrace);
+  }
+
   static String? get matomoVisitorId => MatomoTracker.instance.visitor.id;
 }
 

diff --git a/packages/smooth_app/lib/l10n/app_en.arb b/packages/smooth_app/lib/l10n/app_en.arb
@@ -538,6 +538,10 @@
     "@crop_page_action_local": {
         "description": "Action being performed on the crop page"
     },
+    "crop_page_action_local_failed": "An error occurred while saving the image. Please try again later.",
+    "@crop_page_action_local_failed": {
+        "description": "The save of the picture locally failed"
+    },
     "crop_page_too_small_image_title": "The image is too small!",
     "@crop_page_too_small_image_title": {
         "description": "Title of a dialog warning the user that the image is too small for upload"

diff --git a/packages/smooth_app/lib/pages/crop_page.dart b/packages/smooth_app/lib/pages/crop_page.dart
@@ -17,6 +17,7 @@ import 'package:smooth_app/database/local_database.dart';
 import 'package:smooth_app/generic_lib/design_constants.dart';
 import 'package:smooth_app/generic_lib/dialogs/smooth_alert_dialog.dart';
 import 'package:smooth_app/generic_lib/loading_dialog.dart';
+import 'package:smooth_app/helpers/analytics_helper.dart';
 import 'package:smooth_app/helpers/database_helper.dart';
 import 'package:smooth_app/helpers/image_compute_container.dart';
 import 'package:smooth_app/helpers/image_field_extension.dart';
@@ -227,7 +228,7 @@ class _CropPageState extends State<CropPage> {
   /// Returns a small file with the cropped image, for the transient image.
   ///
   /// Here we use BMP format as it's faster to encode.
-  Future<File> _getCroppedImageFile(
+  Future<File?> _getCroppedImageFile(
     final Directory directory,
     final int sequenceNumber,
   ) async {
@@ -239,7 +240,17 @@ class _CropPageState extends State<CropPage> {
       maxSize: _screenSize.longestSide,
     );
     setState(() => _progress = appLocalizations.crop_page_action_local);
-    await saveBmp(file: result, source: cropped);
+
+    try {
+      await saveBmp(file: result, source: cropped)
+          .timeout(const Duration(seconds: 10));
+    } catch (e, trace) {
+      setState(
+          () => _progress = appLocalizations.crop_page_action_local_failed);
+      AnalyticsHelper.sendException(e, stackTrace: trace);
+      return null;
+    }
+
     return result;
   }
 
@@ -305,11 +316,15 @@ class _CropPageState extends State<CropPage> {
         await getNextSequenceNumber(daoInt, _CROP_PAGE_SEQUENCE_KEY);
     final Directory directory = await getApplicationSupportDirectory();
 
-    final File croppedFile = await _getCroppedImageFile(
+    final File? croppedFile = await _getCroppedImageFile(
       directory,
       sequenceNumber,
     );
 
+    if (croppedFile == null) {
+      return null;
+    }
+
     setState(
       () => _progress = appLocalizations.crop_page_action_server,
     );